Reinstall node_modules on payload latest runs into middleware issue again

notchr2 years ago

19

payload.init({
    secret: process.env.PAYLOAD_SECRET,
    mongoURL: process.env.MONGODB_URI,
    express: app,
    onInit: () => {
      payload.logger.info(`Payload Admin URL: ${payload.getAdminURL()}`);
      router.use(payload.authenticate); // OK
    },
  });
  
  // router.use(payload.authenticate);  (undefined)

• 

  jmikrut

  2 years ago

  it's fine to do that in

  onInit

  for sure but the real question is, what has changed?

• 

  notchr2 years ago

  Exactly, nothing has 😮 (at least in my code)

  
  
  

  We tried to install the lexical plugin earlier today

• 

  jmikrut

  2 years ago

  can you show me your full server file?

• 

  notchr2 years ago

  And I then removed it

  
  
  

  sure thing

  
  
  https://gist.github.com/notchris/93c78db75e4cf8e9388c1b63ef8408e8
  
  

  Had to make a gist, dont have nitro on this work discord

  
  
  

  Also, everything works with the payload.authenticate inside the onInit function

  
  
  

  Otherwise, outside, it is undefined (even after init)

• 

  jmikrut

  2 years ago

  well i want to see what

  doesn't

  work

  
  
  

  where did you have it when it did not work?

• 

  notchr2 years ago

  ah here

  
  
  

  payload.init({
      secret: process.env.PAYLOAD_SECRET,
      mongoURL: process.env.MONGODB_URI,
      express: app,
      onInit: () => {
        payload.logger.info(`Payload Admin URL: ${payload.getAdminURL()}`);
        router.use(payload.authenticate); // OK
      },
    });
    
    // router.use(payload.authenticate);  (undefined)

  
  
  

  payload.authenticate is undefined there

  
  
  

  if uncommented

• 

  jmikrut

  2 years ago

  yea

  
  
  

  so this is because you are not awaiting

  payload.init
  
  

  it's an async call

• 

  notchr2 years ago

  😮

  
  
  

  How did it work prior

• 

  jmikrut

  2 years ago

  it is probably just up to the luck of the draw

  
  
  

  sometimes it works, sometimes it doesn't depending on how fast your code executes payload.init

• 

  notchr2 years ago

  omg

• 

  jmikrut

  2 years ago

  maybe a dependency updated that slowed down mongo connection or something, or schema creation, or graphql, etc

• 

  notchr2 years ago

  its in the docs too

  
  
  

  how did i miss this?

• 

  jmikrut

  2 years ago

  no worries

• 

  notchr2 years ago

  Was it always wrapped in a func

• 

  jmikrut

  2 years ago

  well, that was one of the breaking changes in 1.6.0

  
  
  

  but it's been like that for over a month

• 

  notchr2 years ago

  ugh im such a dummy

• 

  jmikrut

  2 years ago

  maybe 2

• 

  notchr2 years ago

  One day im going to find a real bug that wasn't just me not reading correctly

  
  
  

  Thanks for your time man, my bad

• 

  jmikrut

  2 years ago

  no problem!!!

  
  
  

  happy to help